Fix: Warn about incorrect file inside public folder#299
Merged
Mortaro merged 5 commits intonullstack:unstable-nextfrom Dec 21, 2022
Merged
Fix: Warn about incorrect file inside public folder#299Mortaro merged 5 commits intonullstack:unstable-nextfrom
Mortaro merged 5 commits intonullstack:unstable-nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
Having a file inside public folder named icon-x.png or icon-.png will throw an error due to an uncaught exception while splitting the file name.
The solution:
Add a warning message about the file, without actually preventing the execution if that's intended by the user of Nullstack.