Skip to content

Switch to pnpm at pr-tests CI#346

Merged
Mortaro merged 1 commit intonullstack:nextfrom
GuiDevloper:use-pnpm-ci
May 21, 2023
Merged

Switch to pnpm at pr-tests CI#346
Mortaro merged 1 commit intonullstack:nextfrom
GuiDevloper:use-pnpm-ci

Conversation

@GuiDevloper
Copy link
Member

@GuiDevloper GuiDevloper commented May 20, 2023

When checking if a PR were buggy or was a timeout error in CI I discovered the stressful current wait for the CI itself to run.

This GitHub Action took 16min to run. Even forgot about that in such a time.
Then I was looking around for the reason and found a slow npm resolving (e.g. SWC versions), auditing, installing and then linking deps.

Started to experiment using pnpm there (like in my local environment), it's defaults behaviors priorizes doing everything together and excludes auditing step. This Action run shows it working with cache.

Manager No Cache Cached
npm Up to 20min 3min
pnpm Up to 5min 2min

No behavior changed and it comes testing for conflicts with pnpm like this 😁

How to use

  • Merge in master/next
  • Make a PR against that branch
  • Re-run the job or add commit to see cache in action

Notes for the future

  • The minimum required Node.js version noted at docs should really be changed from v12 to the real v14
  • pnpm version should be 7 for Node14
  • As warned at every Action run, Node.js 12 actions are deprecated. As detailed here in summer 2023 GitHub will switch straight to Node16, then we'll need to update for Actions v3 and lironavon/docker-puppeteer-container:16

@Mortaro Mortaro merged commit 4a7ac8a into nullstack:next May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants