Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking if a PR were buggy or was a timeout error in CI I discovered the stressful current wait for the CI itself to run.
This GitHub Action took 16min to run. Even forgot about that in such a time.
Then I was looking around for the reason and found a slow
npmresolving (e.g. SWC versions), auditing, installing and then linking deps.Started to experiment using
pnpmthere (like in my local environment), it's defaults behaviors priorizes doing everything together and excludes auditing step. This Action run shows it working with cache.How to use
Notes for the future
pnpmversion should be 7 for Node14Node.js 12 actions are deprecated. As detailed here in summer 2023 GitHub will switch straight to Node16, then we'll need to update for Actions v3 andlironavon/docker-puppeteer-container:16