Skip to content

✨ bind date #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mortaro merged 1 commit into from
May 23, 2023
+35 −0
Merged

✨ bind date #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ export function generateCallback(selector, name) {
object[property] = event.target[valueName] === 'true'
} else if (typeof object[property] === 'number') {
object[property] = +event.target[valueName] || 0
} else if (object[property] instanceof Date) {
const [yyyy, mm, dd] = event.target[valueName].split('-')
object[property].setFullYear(yyyy)
object[property].setMonth(+mm - 1)
object[property].setDate(dd)
object[property] = object[property]
} else {
object[property] = event.target[valueName]
}
Expand Down
5 changes: 5 additions & 0 deletions plugins/bindable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ function transform({ node, environment }) {
node.children = [object[property] ?? '']
} else if (node.type === 'input' && node.attributes.type === 'checkbox') {
node.attributes.checked = object[property]
} else if (node.type === 'input' && node.attributes.type === 'date' && object[property] instanceof Date) {
const yyyy = object[property].getFullYear()
const mm = (object[property].getMonth() + 1).toString().padStart(2, '0')
const dd = object[property].getDate().toString().padStart(2, '0')
node.attributes.value = `${yyyy}-${mm}-${dd}`
} else {
node.attributes.value = object[property] ?? ''
}
Expand Down
9 changes: 9 additions & 0 deletions tests/src/TwoWayBindings.njs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class TwoWayBindings extends Nullstack {
boolean = true
character = 'a'
text = 'aaaa'
date = new Date()

object = { count: 1 }
array = ['a', 'b', 'c']
Expand Down Expand Up @@ -143,6 +144,14 @@ class TwoWayBindings extends Nullstack {
>
rebounce
</button>
<input
type="date"
bind={this.date}
data-instanceof-date={this.date instanceof Date}
data-date={this.date.getDate()}
data-month={this.date.getMonth() + 1}
data-year={this.date.getFullYear()}
/>
</div>
)
}
Expand Down
15 changes: 15 additions & 0 deletions tests/src/TwoWayBindings.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,4 +257,19 @@ describe('TwoWayBindings', () => {
const element = await page.$('[data-render-clicked-and-inputed]')
expect(element).toBeTruthy()
})

test('dates can be bound to date inputs', async () => {
await page.$eval('[data-instanceof-date]', (element) => {
element.focus()
element.value = '1992-10-16'
element.blur()
const event = new Event('input')
element.dispatchEvent(event)
})
await page.waitForSelector('[data-date="16"]')
await page.waitForSelector('[data-month="10"]')
await page.waitForSelector('[data-year="1992"]')
const element = await page.$('[data-date="16"]')
expect(element).toBeTruthy()
})
})