Updating & reenabling auto PR testing#396
Open
GuiDevloper wants to merge 2 commits intonullstack:masterfrom
Open
Updating & reenabling auto PR testing#396GuiDevloper wants to merge 2 commits intonullstack:masterfrom
GuiDevloper wants to merge 2 commits intonullstack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just updated to make it work again and retry tests that always been flaky (occasionally fail because of the CI environment).
Extras
Also letting here the possibility to change the Node version we test on (and need to be voted/decided which would be best) and/or test in many of them, I successfully tested even those:
PS: the same could someday be done to package managers, e.g: currently we test on pnpm v7 and before the recent versions (which people probably been using more) that are requiring a
approve-buildshere,--shamefullyHoistthere, etc