Skip to content

TST: Fix test_warning_calls on Python 3.12#25628

Merged
seberg merged 1 commit intonumpy:mainfrom
QuLogic:fix-warning-test
Jan 19, 2024
Merged

TST: Fix test_warning_calls on Python 3.12#25628
seberg merged 1 commit intonumpy:mainfrom
QuLogic:fix-warning-test

Conversation

@QuLogic
Copy link
Copy Markdown
Contributor

@QuLogic QuLogic commented Jan 19, 2024

It currently raises a warning:

DeprecationWarning: Attribute s is deprecated and will be removed in Python 3.14; use value instead

AFAICT, the value attribute has always existed (at least in supported versions of Python 3.)

It currently raises a warning:
```
DeprecationWarning: Attribute s is deprecated and will be removed in Python 3.14; use value instead
```
AFAICT, the `value` attribute has always existed (at least in supported
versions of Python 3.)
@seberg
Copy link
Copy Markdown
Member

seberg commented Jan 19, 2024

Looks right and works, thanks @QuLogic (you may find similar code in SciPy).

(Test doesn't run on pypy, as it is slow, so no point in waiting)

@seberg seberg merged commit c7d7af5 into numpy:main Jan 19, 2024
@QuLogic QuLogic deleted the fix-warning-test branch January 19, 2024 10:41
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jan 19, 2024
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants