BLD: change file extension for libnpymath on win-arm64 from .a to .lib#29750
Merged
mattip merged 2 commits intonumpy:mainfrom Sep 14, 2025
Merged
BLD: change file extension for libnpymath on win-arm64 from .a to .lib#29750mattip merged 2 commits intonumpy:mainfrom
mattip merged 2 commits intonumpy:mainfrom
Conversation
Member
Author
|
Wheel builds tested on my fork, see this CI log. Relevant line: It's |
mattip
reviewed
Sep 13, 2025
[skip ci] Co-authored-by: Matti Picus <[email protected]>
Member
|
Thanks @rgommers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-29577
Should work fine, if it doesn't for some reason then we'll notice in downstream CI jobs that consume nightly wheels.