Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
This also includes #29278, which is what's causing the mypy_primer diff |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I added #29278 to get rid of an mypy error. Is there a better way? |
Member
The only relevant bit of #29278 is the change in And I see that you removed the problematic ignore comments in |
cd36b71 to
c3b3c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29749.
https://mypy.readthedocs.io/en/stable/changelog.html#mypy-1-18
It's should be significantly faster now (~0.67x in case of scipy-stubs), and solves some issues that used to lead to some incorrectly inferred types in our type-tests (e.g.
np.vstack)