BUG: np.setbufsize should raise ValueError for negative input#29798
Merged
charris merged 2 commits intonumpy:maintenance/2.3.xfrom Sep 23, 2025
Merged
BUG: np.setbufsize should raise ValueError for negative input#29798charris merged 2 commits intonumpy:maintenance/2.3.xfrom
charris merged 2 commits intonumpy:maintenance/2.3.xfrom
Conversation
np.setbufsize previously accepted negative values silently. This commit adds input validation so that a ValueError is raised when a negative buffer size is provided, and adds a regression test to cover this behavior. Closes numpy#29651
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29774 .
Closes #29651
This PR fixes an issue where
np.setbufsizesilently accepted negativevalues. Passing a negative value now raises a
ValueErrorwith a clearerror message.
Changes
np.setbufsizeto raiseValueErrorwhensize < 0.test_negative_value_raisesinnumpy/_core/tests/test_umath.py.Example