BUG: Add test to reproduce problem described in #30816#30818
BUG: Add test to reproduce problem described in #30816#30818seberg merged 7 commits intonumpy:mainfrom
Conversation
|
If CI fails, that might be interesting for gh-30816. Otherwise, this PR can be closed probably. If it fails, it might make sense to convert it to a proper test. But then without the |
|
@seberg, thanks a lot for triggering the CI. The run reflects the issue quite well, as the added test only fails in |
|
Yeah, does indeed reproduce, nice: |
|
@seberg, sorry that I didn't get back to this. Frankly speaking, I still don't understand where exactly the problem lies. Our test vector is rather large ( |
d7d52bd to
cdfadce
Compare
cdfadce to
6cdfcef
Compare
|
@seberg, the test I just added seems more reasonable to me. It only fails on the |
|
One observation: The test below passes on all platforms, so the problem is not just array size. def test_norm_linux_arm(self) -> None:
a = np.arange(20000)
norm = np.linalg.norm(a)
assert_almost_equal(norm, 1632931.9244843002) |
|
There is a linting failure |
|
Interesting. So the test passes when using ints, but fails for complex: |
|
I pushed an update to use the new scipy-openblas 0.31.159.0, which will report its version number in the meson build and in |
|
In this comment, NumPy 2.4.3 successfully passes the test if the shared object from |
|
Progress. I found a cfarm build machine with SVE. I can reproduce the problem using the test here. It reproduces with all the scipy-openblas wheels. I will respond on the issue. |
|
I updated scipy-openblas but apparently pypi has not percolated the change out yet. Restarting the failing CI to get the newer version. |
|
the new test is passing. The failure is because I did not update the numpy/numpy-release repo with the newer scipy-openblas version. |
|
the updated scipy-openblas is now part of the requirements for numpy-release, and rerunning the failing check tests now passes. @denialhaag can you confirm this fixes the problem? |
|
Yes, looks good to me! Thanks a lot for all the effort! |
seberg
left a comment
There was a problem hiding this comment.
Thanks for the testing @denialhaag and figuring out the issue Matti!
np.linalg.norm on ARM Linux
np.linalg.norm on ARM Linux) Co-authored-by: mattip <[email protected]>
This PR adds a test case and fixes #30816.