BUG: Fix weak hash function in np.isin().#30840
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Feb 16, 2026
Merged
Conversation
In a build of NumPy against libcxx, we found the following code
regressed from almost instantaneous with NumPy 2.3 to over 40s with
NumPy 2.4.
```
import numpy as np
full_list = np.array("2015-12-01T00:00:00.000000000", 'datetime64[ns]') + np.arange(162143) * np.timedelta64(4, 'h').astype('timedelta64[ns]')
sampled_dates = full_list[10:28]
np.isin(sampled_dates, full_list)
```
Our belief is the following:
* std::unordered_set in libcxx uses power of two hash buckets.
* std::hash is the identity function.
* in this particular example, we are hashing integers (datetime64
values) separated by multiples of a power of two.
* the net result is that all of the integers end up in the same hash
bucket.
We can make the code more robust simply by using the same npy_fnv1a hash
used elsewhere in the same file since it will do a better job of
distributing hash bits.
Contributor
Author
Contributor
|
Nice catch! Using npy_fnv1a seems like a solid fix. |
Member
Agreed, thanks for the detailed analysis and fix. I think it was probably an oversight not to use fnv1a in the first place. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Feb 19, 2026
charris
added a commit
that referenced
this pull request
Feb 19, 2026
BUG: Fix weak hash function in np.isin(). (#30840)
sabasiddique1
pushed a commit
to sabasiddique1/numpy
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a build of NumPy against libcxx, we found the following code regressed from almost instantaneous with NumPy 2.3 to over 40s with NumPy 2.4.
Our belief is the following:
We can make the code more robust simply by using the same npy_fnv1a hash used elsewhere in the same file since it will do a better job of distributing hash bits.