Skip to content

ENH: Test .kind not .char in np.testing.assert_equal (#30879)#30955

Merged
charris merged 1 commit intonumpy:maintenance/2.4.xfrom
charris:backport-30879
Mar 7, 2026
Merged

ENH: Test .kind not .char in np.testing.assert_equal (#30879)#30955
charris merged 1 commit intonumpy:maintenance/2.4.xfrom
charris:backport-30879

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Mar 7, 2026

Backport of #30879.

This PR makes assert_equal correctly handle NaN tests for user-defined float types.

This fixes an issue found when attempting to port ml_dtypes to use the NumPy 2 user dtype APIs (jax-ml/ml_dtypes#360).

@charris charris added 01 - Enhancement 08 - Backport Used to tag backport PRs labels Mar 7, 2026
@charris charris added this to the 2.4.3 release milestone Mar 7, 2026
@charris charris merged commit 254bafa into numpy:maintenance/2.4.x Mar 7, 2026
73 checks passed
@charris charris deleted the backport-30879 branch March 7, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01 - Enhancement 08 - Backport Used to tag backport PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants