Open
Conversation
juliagallucci
suggested changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Part A of the assignment does not work in all instances, ie Silent, listen should return True but your code gives false! Hint: case sensitivity is not relevant for part A.
Please revise and resubmit
juliagallucci
approved these changes
May 7, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great! My suggestion for improvement would be to better comment your code for improved clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
The code is added to anagram_checker function without case sensitive check and with
What did you learn from the changes you have made?
I learned how to work with strings using sorted and upper methods and then compare prepared strings to check if they are anagrams
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I believe there are a lot of ways to manipulate the strings using python language, I tried to use the ones introduced during the learning session
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I got the error about the type can not use sorted function
How were these changes tested?
the code was executed without errors
A reference to a related issue in your repository (if applicable)
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist