Skip to content

UofT-DSI | Python - Assignment-1#1

Open
nurkanovat wants to merge 2 commits intomainfrom
assignment-1
Open

UofT-DSI | Python - Assignment-1#1
nurkanovat wants to merge 2 commits intomainfrom
assignment-1

Conversation

@nurkanovat
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

The code is added to anagram_checker function without case sensitive check and with

What did you learn from the changes you have made?

I learned how to work with strings using sorted and upper methods and then compare prepared strings to check if they are anagrams

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I believe there are a lot of ways to manipulate the strings using python language, I tried to use the ones introduced during the learning session

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I got the error about the type can not use sorted function

How were these changes tested?

the code was executed without errors

A reference to a related issue in your repository (if applicable)

@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part A of the assignment does not work in all instances, ie Silent, listen should return True but your code gives false! Hint: case sensitivity is not relevant for part A.

Please revise and resubmit

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! My suggestion for improvement would be to better comment your code for improved clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants