Skip to content

WIP: Add curl downloader #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1n7ax merged 1 commit into from
Feb 4, 2026
Merged

WIP: Add curl downloader #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions lua/pkgm/downloaders/curl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
local path = require('java-core.utils.path')
local class = require('java-core.utils.class')
local log = require('java-core.utils.log2')

---@class java-core.Curl
---@field url string
---@field dest string
---@field retry_count number
---@field timeout number
local Curl = class()

---@class java-core.CurlOpts
---@field url string URL to download
---@field dest? string Destination path (optional, uses temp if not provided)
---@field retry_count? number Retry count (optional, defaults to 5)
---@field timeout? number Timeout in seconds (optional, defaults to 30)

---@param opts java-core.CurlOpts
function Curl:_init(opts)
self.url = opts.url

if not opts.dest then
local filename = vim.fs.basename(opts.url)
local tmp_dir = vim.fn.tempname()
vim.fn.mkdir(tmp_dir, 'p')
self.dest = path.join(tmp_dir, filename)
log.debug('Using temp destination:', self.dest)
else
self.dest = opts.dest
log.debug('Using provided destination:', self.dest)
end

self.retry_count = opts.retry_count or 5
self.timeout = opts.timeout or 30
end

---Download file using curl
---@return string|nil # Path to downloaded file, or nil on failure
---@return string|nil # Error message if failed
function Curl:download()
log.debug('curl downloading:', self.url, 'to', self.dest)
local cmd = string.format(
'curl --retry %d --connect-timeout %d -o %s %s',
self.retry_count,
self.timeout,
vim.fn.shellescape(self.dest),
vim.fn.shellescape(self.url)
)
log.debug('curl command:', cmd)

local result = vim.fn.system(cmd)
local exit_code = vim.v.shell_error

if exit_code ~= 0 then
log.error('curl failed:', exit_code, result)
return nil, string.format('curl failed (exit %d): %s', exit_code, result)
end

log.debug('curl download completed:', self.dest)
return self.dest, nil
end

return Curl
7 changes: 7 additions & 0 deletions lua/pkgm/downloaders/factory.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
local system = require('java-core.utils.system')
local Curl = require('pkgm.downloaders.curl')
local Wget = require('pkgm.downloaders.wget')
local PowerShell = require('pkgm.downloaders.powershell')
local log = require('java-core.utils.log2')
Expand Down Expand Up @@ -27,6 +28,12 @@ function M.get_downloader(opts)
return Wget(opts)
end

-- Check for curl on all platforms
if vim.fn.executable('curl') == 1 then
log.debug('Using curl downloader')
return Curl(opts)
end

-- On Windows, fallback to PowerShell if available
if os == 'win' and (vim.fn.executable('pwsh') == 1 or vim.fn.executable('powershell') == 1) then
log.debug('Using PowerShell downloader (fallback)')
Expand Down