This repository was archived by the owner on Dec 27, 2022. It is now read-only.
using jsonp to allow for crossdomain xhr requests#27
Closed
captnswing wants to merge 1 commit intoobfuscurity:masterfrom
captnswing:master
Closed
using jsonp to allow for crossdomain xhr requests#27captnswing wants to merge 1 commit intoobfuscurity:masterfrom captnswing:master
captnswing wants to merge 1 commit intoobfuscurity:masterfrom
captnswing:master
Conversation
Owner
|
@captnswing - Tasseo used to do JSONP. Unfortunately, there is a significant memory leak condition when using JSONP. I'm surprised this diff works as submitted. IIRC you need to also set |
Author
|
ok, apologies for not scanning earlier PRs before submitting this. |
Owner
|
@captnswing - No worries. FWIW I'd like to offer JSONP support again, but it will need to be raw javascript without jQuery (as it appears they have no intention on fixing this bug). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graphite seems to support jsonp as of late. I changed tasseo.js to use jsonp in the jQuery.ajax xhr call.
This allows tasseo to be used on another machine than the graphite machine.