Skip to content

[IMP] sales: add a pdf to a product pdf quote builder#17399

Closed
fw-bot wants to merge 1 commit into19.0from
19.0-18.0-sales-pdf-quote-builder-add-pdf-to-products-meval-517716-fw
Closed

[IMP] sales: add a pdf to a product pdf quote builder#17399
fw-bot wants to merge 1 commit into19.0from
19.0-18.0-sales-pdf-quote-builder-add-pdf-to-products-meval-517716-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Collaborator

@fw-bot fw-bot commented Apr 16, 2026

Updated the Add a PDF to a product page by:

  • restructuring the article
  • revising the text to add more detail and context
  • added one image for variant banner

This 18.0 PR can be FWP up to master.

Forward-Port-Of: #17359

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 16, 2026

Pull request status dashboard

@fw-bot fw-bot mentioned this pull request Apr 16, 2026
Closed
@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented Apr 16, 2026

@meval1006 @Felicious cherrypicking of pull request #17359 failed.

stdout:

warning: Cannot merge binary files: content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/document-form-uploaded-pdf.png (ee76df9b6cf2e447c212bbb42c57ddb97a7c69d8 vs. fbe593f19fc83097103480f7ba8961b922845be4)
Auto-merging content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/document-form-uploaded-pdf.png
CONFLICT (content): Merge conflict in content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/document-form-uploaded-pdf.png
warning: Cannot merge binary files: content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/pdf-on-quote-sample.png (ee76df9b6cf2e447c212bbb42c57ddb97a7c69d8 vs. fbe593f19fc83097103480f7ba8961b922845be4)
Auto-merging content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/pdf-on-quote-sample.png
CONFLICT (content): Merge conflict in content/applications/sales/sales/sales_quotations/pdf_quote_builder/add_pdf_products/pdf-on-quote-sample.png

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

:shipit: you can use git-fw to re-do the forward-port for you locally.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@meval1006 @huisit
[IMP] sales: add a pdf to a product pdf quote builder
2d63623 
X-original-commit: dc33eb5
Co-authored-by: Rex <[email protected]>
Co-authored-by: Rex <[email protected]>
Co-authored-by: Rex <[email protected]>
Co-authored-by: Rex <[email protected]>
@meval1006 meval1006 force-pushed the 19.0-18.0-sales-pdf-quote-builder-add-pdf-to-products-meval-517716-fw branch from bba8cec to 2d63623 Compare April 16, 2026 18:10
@meval1006
Copy link
Copy Markdown
Contributor

meval1006 commented Apr 16, 2026

@robodoo r+

@C3POdoo C3POdoo requested a review from a team April 16, 2026 18:12
@robodoo robodoo closed this in 084d167 Apr 16, 2026
This was referenced Apr 16, 2026
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflict forwardport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fw-bot @robodoo @meval1006