Open
Conversation
DwardEE
reviewed
Aug 20, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good job~
Nice diagrams.
In the windowed functions, your DENSE_RANK approach works, though COUNT() in Q3 technically counts rows rather than distinct dates, this is acceptable but can overstate purchases if a customer bought multiples of the same product on the same day.
Overall clear, complete, and accurate. Nothing major to fix.
DwardEE
approved these changes
Aug 20, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good job~
Nice diagrams.
In the windowed functions, your DENSE_RANK approach works, though COUNT() in Q3 technically counts rows rather than distinct dates, this is acceptable but can overstate purchases if a customer bought multiples of the same product on the same day.
Overall clear, complete, and accurate. Nothing major to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment 2 (2 ERDs and SQL code)
What did you learn from the changes you have made?
ERD, window functions, create table / insert / update statements, and other SQL
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
N/A
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Mostly about complex SQL
How were these changes tested?
Tested these changes against SQLite DB
#e# A reference to a related issue in your repository (if applicable)
Checklist