Conversation
There was a problem hiding this comment.
Add a blank line above and 4 space indent this to make MD format it as code?
gem 'omniauth-github'
|
Maybe we should add deprecation notices for |
|
There isn't a deprecation AFAIK, just a slight rename so a deprecation warning wouldn't be necessary. |
|
@testbrian Thanks, this guide is very helpful. It is unfortunate that this PR was not accepted as it is currently a bit hard to find. |
b497860 to
9c90d0b
Compare
|
How about merging then? |
|
@matkoniecz @testbrian Hey guys! I just got added to the repo and I'm going through old PRs. Considering that Omniauth and this gem, in particular, isn't specific to Rails, I'd be hesitant to add this entire setup to the README. With this said it'd work perfectly as a Wiki article which we can link to in the README. I've set up a page here: https://github.com/intridea/omniauth-github/wiki/Rails-Usage What do you think? |
|
Moving to close. |
Changed
ENV['GITHUB_KEY'], ENV['GITHUB_SECRET']toENV['GITHUB_CLIENT_ID'], ENV['GITHUB_CLIENT_SECRET']to match Github credentials and added a little info.