Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
PR Summary
This PR optimizes document tag deletion performance and modifies email header handling, with key changes focused on query efficiency and email configuration.
- Improved orphan tag deletion in
/backend/onyx/db/tag.pyby replacing outer join/group by with a more efficient NOT EXISTS subquery - Added conditional 'From' header check in
/backend/onyx/auth/email_utils.pythat needs review as missing headers could cause email delivery failures - Query optimization removes dependency on SQLAlchemy's
funcmodule while maintaining correct tag identification
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+156
to
+157
| if mail_from: | ||
| msg["From"] = mail_from |
Contributor
There was a problem hiding this comment.
logic: Removing the 'From' header when mail_from is None will cause email delivery failures. The 'From' header is required by SMTP. Should use EMAIL_FROM as fallback instead.
Suggested change
| if mail_from: | |
| msg["From"] = mail_from | |
| msg["From"] = mail_from or EMAIL_FROM |
Weves
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-1543.
https://linear.app/danswer/issue/DAN-1543/slow-doc-tag-deletion-contributor
Credit to @ThomaciousD - #4192
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.