Merged
Conversation
When compiling the library, the resulting .whl will only be compatible against the same exact python version it was compiled against. By specifying an abi minimum compatibility we make the library compatible with multiple python version. abi3-py310 for example makes the resulting wheel compatible with any python version higher than 3.10 This change is required to make the library easier to compile and compatible with ooniprobe See: - https://pyo3.rs/main/features.html#abi3 - https://pyo3.rs/main/building-and-distribution#py_limited_apiabi3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will change the
ooniauth-pyAPI to use strings instead of byte arrays to simplify usage in Python landEncoding of binary data structures into string is made with
base64encodingcloses #11