Skip to content

fix(issue,53): fixed duplicated required options in export and import#60

Merged
shreyas-lyzr merged 1 commit intoopen-gitagent:mainfrom
niltonfrederico:main
Mar 31, 2026
Merged

fix(issue,53): fixed duplicated required options in export and import#60
shreyas-lyzr merged 1 commit intoopen-gitagent:mainfrom
niltonfrederico:main

Conversation

@niltonfrederico
Copy link
Copy Markdown
Contributor

What

Fixed the duplicate requiredOption in both import.ts and export.ts

Why

Closes #

How Tested

  • npm run build passes
image
  • gitagent validate passes on example agents
image
  • Manual testing (describe below)
    Manual testing was done by just using the generated build to run gitagent validate and the import and export commands

Export:
image

Import:
image

Checklist

  • My code follows the existing style of this project
  • [N/A] I have added/updated tests (if applicable)
  • [N/A] I have updated documentation (if applicable)
  • I have read the CONTRIBUTING.md

@shreyas-lyzr shreyas-lyzr merged commit cf029df into open-gitagent:main Mar 31, 2026
@shreyas-lyzr
Copy link
Copy Markdown
Contributor

Reviewed and merged with an additional fix.

What the PR fixed correctly:

  • Duplicate .requiredOption() calls merged into one (both export and import)
  • Indentation fixed on gemini/codex case blocks

Additional fix applied:
The case 'codex' was placed after default: with no break in the default block. This caused two bugs:

  1. Unknown formats fell through into the codex handler instead of exiting
  2. The format lists in error messages were split across two info() calls

Fixed by moving case 'codex' before default: with a proper break, and merging the format list into one complete string.

Thanks @niltonfrederico for catching #53!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants