Skip to content

Regexp matchers for method names | "^=", "$=" and "*=" #5

Closed
LTe wants to merge 1 commit intoopenSUSE:masterfrom
LTe:method_name_regexp
Closed

Regexp matchers for method names | "^=", "$=" and "*=" #5
LTe wants to merge 1 commit intoopenSUSE:masterfrom
LTe:method_name_regexp

Conversation

@LTe
Copy link
Copy Markdown
Member

@LTe LTe commented Jun 8, 2012

I have problem with dynamic method names:

find_by_id
find_by_id_and_name
# etc

Method names in Rubinius::AST have symbol value. In parser we can only use regexp with strings.

@LTe
Copy link
Copy Markdown
Member Author

LTe commented Jun 12, 2012

One small thing: Please make sure that wherever some string-related stuff and symbol-related stuff is placed together at one place, they are placed in the same order. This helps readers to orient better in the code a bit.

  • Symbol related
  • String related

In this order (in specs, parser definition and class order in matchers.rb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants