Closed
Conversation
Create Scanny::VERSION and use this constant in scanny.gemspec file
Dynamic formats for report Require custom checks Remove constants of disabled checks Scan ./ directory by default
Require all files with .rb extension (require checks) Move show_version to Scanny::Tools In case of wrong output format exit with status 1
Contributor
|
Given the number of issues and suggested changes I'd say it would be best to implement the CLI from the ground up in a step-wise fashion. The steps would help us untangle various issues, make a nice git history and help me review. This is a list of steps I'd suggest (each basically means one commit, best in its own pull request so that we merge the code in gradually).
Specs should generally come in the same commit as the code they describe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.