Skip to content

Parser mode for scanny#89

Merged
dmajda merged 2 commits intoopenSUSE:masterfrom
LTe:19_and_18mode
Aug 2, 2012
Merged

Parser mode for scanny#89
dmajda merged 2 commits intoopenSUSE:masterfrom
LTe:19_and_18mode

Conversation

@LTe
Copy link
Copy Markdown
Member

@LTe LTe commented Aug 2, 2012

User can select parser. For example old applications need to use 1.8 parser.

scanny --mode 18 ./my/app

or

scanny --mode 19 ./my/app

LTe added 2 commits August 2, 2012 09:52
User can use 18 mode (1.8.7 parser) and 19 mode (1.9.3 parser)
@LTe
Copy link
Copy Markdown
Member Author

LTe commented Aug 2, 2012

I'll rephrase and expand what I wrote on IRC in case that didn't reach you because of Freenode's problems: I'd just pass the parser to Runner#initialize and make the attribute in Runner immutable.

Passing in the initializer makes this an instance of dependency injection which is generally an useful pattern to adhere to.

The immutability is generally a good thing because it lowers the number of states an object can be in. This usually leads to simpler and less buggy code.

@dmajda Updated

dmajda added a commit that referenced this pull request Aug 2, 2012
@dmajda dmajda merged commit 2f65b7f into openSUSE:master Aug 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants