fix: remove hardcoded image.tag to use Chart.AppVersion#239
Merged
thepagent merged 1 commit intoopenabdev:mainfrom Apr 12, 2026
Merged
Conversation
thepagent
requested changes
Apr 12, 2026
Collaborator
thepagent
left a comment
There was a problem hiding this comment.
The image.tag: "" fix is correct, but this PR also rewrites the entire values.yaml from the old flat structure (discord.*, agent.*, pool.*) to the new agents.kiro.* structure. That migration was already done on main — so this diff is re-applying a change that already exists.
If merged as-is, it could overwrite recent additions (e.g. the stt block from #228) or cause merge conflicts.
Suggested fix: Please rebase onto latest main and reduce the diff to just the one-line change:
image:
tag: "" # was: "94253a5" (or "78f8d2c")Everything else in values.yaml should already match main after rebase.
Set image.tag to empty string so the Helm template falls back to .Chart.AppVersion. Closes openabdev#235
9d123ab to
9b985de
Compare
thepagent
approved these changes
Apr 12, 2026
Collaborator
thepagent
left a comment
There was a problem hiding this comment.
LGTM — clean one-liner, falls back to Chart.AppVersion as intended.
pahud
previously approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
image.tagto an empty string incharts/openab/values.yamlso the Helm template falls back to.Chart.AppVersion.Root Cause
image.tagwas hardcoded to a commit hash (94253a5), which preventedhelm upgradefrom picking up theappVersiondefined inChart.yaml. Deployed pods ran an outdated binary as a result.Fix
The existing template logic in
_helpers.tpl:will now correctly resolve to the chart's
appVersion(0.7.0-beta.1).Closes #235