[Azure] CLI: Add support for azure openai chat completion API#359
Merged
athyuttamre merged 1 commit intoopenai:mainfrom Apr 4, 2023
Merged
[Azure] CLI: Add support for azure openai chat completion API#359athyuttamre merged 1 commit intoopenai:mainfrom
athyuttamre merged 1 commit intoopenai:mainfrom
Conversation
Contributor
Author
|
@athyuttamre could you help review? |
athyuttamre
reviewed
Apr 4, 2023
athyuttamre
reviewed
Apr 4, 2023
athyuttamre
approved these changes
Apr 4, 2023
athyuttamre
left a comment
There was a problem hiding this comment.
Two non-blocking comments, thanks for the PR!
Contributor
Author
|
@athyuttamre Thank you for the review. Updated based on your comment. |
athyuttamre
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
LGTM! I can cut a new release immediately or we can wait for other PRs (#337) from Microsoft to land. What do you prefer?
Contributor
Author
|
@athyuttamre Both should work. As this one works on its own, maybe we can merge it now? |
|
Great! I need a stamp from a teammate to publish a version, will do so once this is approved: #373. |
|
This has been published in https://pypi.org/project/openai/0.27.4/. |
davedittrich
pushed a commit
to davedittrich/openai-python
that referenced
this pull request
Nov 14, 2023
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure API need to pass parameter
engine. Follow the patternCompletion.createto makemodeloptional and addengineas a parameter too.Tested on Azure OpenAI API passed with