Show again that there are open comments#1577
Open
Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Open
Conversation
In the events table, a "comment" icon is displayed for events with comments. Before we switched to lucide icons, there were two different comment icons, depending on if the event still had unresolved comments or not. This behaviour was lost. This patch brings the behaviour back. If there are still unresolved comments, the speech bubble icon now has an exclamation point in it. Why not a filled icon like before? Because lucide does not have that.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1577/2026-04-13_14-58-26/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1544.
In the events table, a "comment" icon is displayed for events with comments. Before we switched to lucide icons, there were two different comment icons, depending on if the event still had unresolved comments or not. This behaviour was lost.
This patch brings the behaviour back. If there are still unresolved comments, the speech bubble icon now has an exclamation point in it.
Why not a filled icon like before? Because lucide does not have that.
How to test this
Can be tested as is. Add comments to an event in the event details, then watch the icons on the right in the events table.