feat: use pull request creator from repo-tools, not testeng-ci#137
Merged
kdmccormick merged 3 commits intoopenedx:masterfrom Jun 7, 2024
Merged
Conversation
testeng-ci is deprecated in favor of repo-tools [1]
This includes some cosmetic changes to the upgrade PRs.
Before:
* branch == jenkins/upgrade-python-requirements-{id}
* title == Python Requirements Update
* commit == chore: Updating Python Requirements
After:
* branch == repo-tools/upgrade-python-requirements-{id}
* title == chore: Upgrade Python requirements
* commit == chore: Upgrade Python requirements
NOTE: This leaves behind a testeng-ci reference in the repo-health job.
We need to figure out whether to fix the repo health dashboard or
deprecate it. This will a follow up task after [1] is closed.
[1] https://github.com/openedx/testeng-ci/issues/419
3dbaa0c to
ac64a4d
Compare
This was referenced Jun 5, 2024
feanil
reviewed
Jun 6, 2024
| pip install -r requirements/base.txt | ||
| git clone https://github.com/openedx/repo-tools.git | ||
| cd $GITHUB_WORKSPACE/repo-tools | ||
| pip install -e '.[pull_request_creator]' |
Contributor
There was a problem hiding this comment.
What about just installing it from PyPI?
Member
Author
There was a problem hiding this comment.
@feanil Can you review openedx/repo-tools#523 ? It'll just push the pull_request_creator change to pypi.
kdmccormick
commented
Jun 6, 2024
kdmccormick
commented
Jun 6, 2024
kdmccormick
commented
Jun 6, 2024
kdmccormick
commented
Jun 6, 2024
feanil
approved these changes
Jun 7, 2024
Contributor
feanil
left a comment
There was a problem hiding this comment.
Looks good once the new version of the pull request creator has been published to PyPI
Member
Author
|
It works! openedx/XBlock#758 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testeng-ci is deprecated in favor of repo-tools.
See the DEPR [1] and the PR that moved pull_request_creator to repo-tools [2].
This also includes some cosmetic changes to the upgrade PRs.
Before:
After:
NOTE: This leaves behind a testeng-ci reference in the repo-health job. We need to figure out the future of the edx-repo-health repo. This will be a future task [3]
[1] openedx/public-engineering#265
[2] openedx/repo-tools#517
[3] #138
Testing
I tested this on the XBlock repo: