Skip to content

Topology: check if index is not empty#194

Merged
abr-ubiqube merged 2 commits intomasterfrom
fix__undefined_index_ipam_device_id
May 20, 2021
Merged

Topology: check if index is not empty#194
abr-ubiqube merged 2 commits intomasterfrom
fix__undefined_index_ipam_device_id

Conversation

@abr-ubiqube
Copy link
Copy Markdown
Member

No description provided.

@abr-ubiqube abr-ubiqube requested a review from UBiqube-ydu May 20, 2021 07:37
@abr-ubiqube abr-ubiqube self-assigned this May 20, 2021
@UBiqube-ydu
Copy link
Copy Markdown
Contributor

The fix is good but if I'm not wrong the same one has to be done in Process_Create_View/Tasks/Task_Create.php

$view_type = $context["view_type"];
if ($context['ipam_device_id']) {
$ipam_device_id = $context['ipam_device_id'];
if (isset($context['ipam_device_id'])) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yvesdumarest, fix done here also

@abr-ubiqube abr-ubiqube merged commit 0fa9686 into master May 20, 2021
@abr-ubiqube abr-ubiqube deleted the fix__undefined_index_ipam_device_id branch May 20, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants