Fixes a bug when running fix_serialization on Kubernetes ExternalName…#161
Merged
fabianvf merged 2 commits intoopenshift:masterfrom Mar 5, 2018
Merged
Fixes a bug when running fix_serialization on Kubernetes ExternalName…#161fabianvf merged 2 commits intoopenshift:masterfrom
fabianvf merged 2 commits intoopenshift:masterfrom
Conversation
… service definitions
Member
|
good catch, I wonder if it might be better to add a check for the ports variable instead though, so it would look like if obj and obj.kind == "Service" and obj.spec.ports:
...That way it will prevent iteration if ports isn't provided in every case. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug popped up when specifically using the k8s_raw module with ansible.
When the
fix_serializationfunction is with a service definition like below it runs into the following error message because no ports need to be specifiedExample service definition:
Error