fix(ci): use commit-count versioning for dev builds and benchmarks#173
Closed
carlos-alm wants to merge 8 commits intomainfrom
Closed
fix(ci): use commit-count versioning for dev builds and benchmarks#173carlos-alm wants to merge 8 commits intomainfrom
carlos-alm wants to merge 8 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.4.1-dev.<sha>because patch was hardcoded toPATCH + 1from package.json. Now usesgit rev-listto count commits since the release tag, giving monotonically increasing versions (2.4.1,2.4.5,2.4.15, etc.)getBenchmarkVersion()(sharedscripts/bench-version.js) which usesgit describeto detect dev vs release state, preventing dev/dogfood benchmark runs from overwriting release data in historical reportsfetch-depth: 0to thecompute-versioncheckout so git history and tags are availableChanges
.github/workflows/publish.ymlPATCH+1withgit rev-listcommit counting, addfetch-depth: 0scripts/bench-version.jsgetBenchmarkVersion(pkgVersion, cwd)scripts/benchmark.jsbenchVersioninstead ofpkg.versionscripts/incremental-benchmark.jsscripts/query-benchmark.jsscripts/embedding-benchmark.jsscripts/token-benchmark.jsTest plan
node -e "import { getBenchmarkVersion } from './scripts/bench-version.js'; console.log(getBenchmarkVersion('2.4.0', '.'))"outputs2.4.0-dev.N+hash(not2.4.0).1