Skip to content

no chrome update shaming#83

Open
ImprovedTube wants to merge 240 commits intooraz:masterfrom
ImprovedTube:patch-1
Open

no chrome update shaming#83
ImprovedTube wants to merge 240 commits intooraz:masterfrom
ImprovedTube:patch-1

Conversation

@ImprovedTube
Copy link
Copy Markdown

if you fill in the blank, i can make another PR or commit like: chrome.runtime.onInstalled.addListener(function(installed){if(installed.reason=='install'){if 111 > Number(navigator.userAgent.match(new RegExp(chrome + '/([0-9]+)'))){alert("[Just to make sure:] Some of our features might require chrome version 111+.... _______________________") } ( - or rather add it precisely, when that feature is first enabled as indicated by it's button or storage change.)

oraz and others added 27 commits February 2, 2022 22:26
if you fill in the blank, i can make another PR or commit like:  `chrome.runtime.onInstalled.addListener(function(installed){if(installed.reason=='install'){if 111 > Number(navigator.userAgent.match(new RegExp(chrome + '/([0-9]+)'))){alert("[Just to make sure:] Some of our features might require chrome version 111+.... _______________________") }`    ( - or rather add it precisely, when that feature is first enabled as indicated by it's button or storage change.)
},
"manifest_version": 3,
"minimum_chrome_version": "110",
"minimum_chrome_version": "1",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for that?
you can't install the extension on Chrome v1
BookmarksMenu is an extension based on Manifest V3. It means that Chrome v88 or newer is required.
See https://developer.chrome.com/docs/extensions/mv3/intro/ for more details
I'm using 110 because of favicons: https://developer.chrome.com/docs/extensions/mv3/favicon/

@ImprovedTube
Copy link
Copy Markdown
Author

hi :) @oraz! the last version for windows 7 is 109 jan 10 2023. Including favicon updates afaik. The end of security updates for windows 7 caused a sudden drop from 10% to 3% in OS market share who stay. (They may be secondary computers / OS.)

( BTW ( might not matter here), manifest3 still had some issue at the start of the year 2023, so we returned to manifest2 (only requires changes in the manifest, for us.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants