Closed
Conversation
Contributor
Author
|
Looks like we don't need to go to 3 yet; can just bump the drawing package to 1.0.0. Opened #2099 ; won't scrub this branch because it might be useful later on |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I need to rebase against develop and a few other things, so this is very much a WIP: don't bother reviewing it yet)
ImageSharp is out of beta, and the old libraries have listed vulnerabilities, so this bumps everything to the latest versions.
This requires targeting net6.0, so we lose netstandard and netframework support.
Checklist
Just done a very quick refit so far, and doesn't look painful.
Outstanding issues:
DrawImagedoesn't work: may be possible to significantly simplify the method as there are some useful lookingDrawImageoverloads in ImageSharp now (though AFAIKT none that does the job in one)DrawTextuses a hideous hard-coded path length because the old methods we used doesn't exist; may be that there is a nicer API for drawing text that doesn't involve laying out the glyphs etc. as is probably necessary for proper emoji support@oxyplot/admins