Generalize subscripts using collections.abc module#23
Merged
dmlb2000 merged 1 commit intopacifica:masterfrom May 20, 2019
Merged
Generalize subscripts using collections.abc module#23dmlb2000 merged 1 commit intopacifica:masterfrom
dmlb2000 merged 1 commit intopacifica:masterfrom
Conversation
dmlb2000
approved these changes
May 20, 2019
Member
dmlb2000
left a comment
There was a problem hiding this comment.
This looks fine by me, I like how you didn't have the change the test suite to fix this. Might consider adding another pull request to enhance the test suite with example inherited classes to show the functionality @niflostancu is talking about in his issue.
Member
|
@niflostancu Does this feature meet your needs? |
|
Wow, that was fast. It's perfect for my use case, and, possibly, others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
isinstance(x, dict)withisinstance(x, collections.abc.Mapping).Replaces
isinstance(x, list)withisinstance(x, collections.abc.Sequence) and not isinstance(x, str).Issues Resolved
Closes #20
Check List