Skip to content

Change the VERSION file name in tarball.#75

Open
chaplaev wants to merge 1 commit intopackpack:masterfrom
chaplaev:fix-version
Open

Change the VERSION file name in tarball.#75
chaplaev wants to merge 1 commit intopackpack:masterfrom
chaplaev:fix-version

Conversation

@chaplaev
Copy link
Copy Markdown

@chaplaev chaplaev commented Jun 8, 2017

Generating the VERSION file can break sources
that already contain it, e.g. mysql.

Generating the VERSION file can break sources
that already contain it, e.g. mysql.
@rtsisyk
Copy link
Copy Markdown
Member

rtsisyk commented Jun 8, 2017

OK, I've got it. Let me think about this problem a little bit.

@rtsisyk rtsisyk self-requested a review June 8, 2017 17:38
@sergeyklay
Copy link
Copy Markdown
Contributor

@rtsisyk What kind of issues do you mean? Could you please elaborate on that?

@chaplaev
Copy link
Copy Markdown
Author

chaplaev commented Jun 8, 2017

Let me explain the situation in more detail. For example, mysql has its own VERSION file (see https://github.com/mysql/mysql-server/blob/5.7/VERSION). packpack at the stage of tarball creating rewrites it, which leads to errors during futher compilation.

Quite frankly, I did not really understand where the contents of this file are later used, so I just changed its name in the patch.

Perhaps it makes sense to refuse to create this file at all, however, at the moment it breaks down the building of projects containing a file with that name in topdir.

@kostja
Copy link
Copy Markdown
Contributor

kostja commented Jun 8, 2017

Just curoius, why don't you file a ticket with them so that they remove it?-)

@akopytov
Copy link
Copy Markdown
Member

akopytov commented Jun 8, 2017

@kostja I guess that was a joke, but since the reporter may take it seriously and waste his time, no, filing it with MySQL won't work. Besides, I'm sure MySQL is not the only project having VERSION in the root dir.

@rtsisyk what does packpack use it for? I can't find it in the source too.

@akopytov
Copy link
Copy Markdown
Member

ping?

@Totktonada
Copy link
Copy Markdown
Member

It seems it comes from b1765dd and also used to set PACKVERSION in ${REPO_ROOT}/packpack during packaging of packpack itself (see ${REPO_ROOT}/Makefile).

I think it make sense to skip VERSION file generation if it is already presented.

@Totktonada
Copy link
Copy Markdown
Member

(Unlikely @kostja jokes, he was mysql developer in the past.)

I looked at the VERSION file from mysql. It is not a file with a version string: it uses its own format. We cannot use it here.

Regarding using of VERSION.packpack: it is quite expected behaviour to have a version file in a tarball, named exactly as VERSION. Packpack is used, in particular, for tarballs generation, so I would not change the file name.

It is strange to use one version for building and another one for a package name, but maybe we can keep a version file if it already exists for some reason. I'm still not sure it'll be good solution.

Any other thoughts?

@Totktonada
Copy link
Copy Markdown
Member

As a raw idea: allow to pass your own version file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants