Change the VERSION file name in tarball.#75
Conversation
Generating the VERSION file can break sources that already contain it, e.g. mysql.
|
OK, I've got it. Let me think about this problem a little bit. |
|
@rtsisyk What kind of issues do you mean? Could you please elaborate on that? |
|
Let me explain the situation in more detail. For example, mysql has its own VERSION file (see https://github.com/mysql/mysql-server/blob/5.7/VERSION). packpack at the stage of tarball creating rewrites it, which leads to errors during futher compilation. Quite frankly, I did not really understand where the contents of this file are later used, so I just changed its name in the patch. Perhaps it makes sense to refuse to create this file at all, however, at the moment it breaks down the building of projects containing a file with that name in topdir. |
|
Just curoius, why don't you file a ticket with them so that they remove it?-) |
|
ping? |
|
It seems it comes from b1765dd and also used to set I think it make sense to skip VERSION file generation if it is already presented. |
|
(Unlikely @kostja jokes, he was mysql developer in the past.) I looked at the Regarding using of It is strange to use one version for building and another one for a package name, but maybe we can keep a version file if it already exists for some reason. I'm still not sure it'll be good solution. Any other thoughts? |
|
As a raw idea: allow to pass your own version file name. |
Generating the VERSION file can break sources
that already contain it, e.g. mysql.