Open
Conversation
Contributor
|
This pr is a result of our work on the ZoneMinder project. I encouraged @connortechnology to engage the packpack community, since his questions were beyond my current experience with debian packages. |
Contributor
|
Looks like this is breaking the Traivs check because DIST isn't being properly supplied into the build. |
Author
|
I havn't been able to figure out any way to use $(DIST) in the makefiles. It just isn't populated. But you can populate CHANGELOG_DIST and that seems to work. |
Author
|
This is not breaking travis anymore. |
Contributor
|
Are there any objections to merging this? This would be helpful for the ZoneMinder project. |
Update from upstream master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we are trying to use packpack to generate packages and then use those packages with mini-dinstall to make a ppa for our nightly builds.
Problem is that packpack doesn't set the distro field in the changelog, so it defaults to UNRELEASED which isn't very useful.
This PR adds a variable CHANGELOG_DIST and defaults it to $DIST and uses it on the dch command line to set the distro value.