Conversation
main to assignment-one branch
… assignment-one
l-mack
left a comment
There was a problem hiding this comment.
@pala2003 Please review the feedback on your assignment below. Based on the comments provided, please revise and resubmit the indicated questions:
WHERE, Question 2: You correctly use the AND operator to filter vendor_ids between 8 and 10 and implemented the price calculation however, re-read the exact requirements carefully. The question asks specifically for "all customer purchases" with a calculated price column. Are you selecting exactly what's needed? Consider whether joins are necessary if the question focuses on the customer_purchases table alone. Also, the requirements don't mention grouping or summing data. Think about whether GROUP BY and SUM() are needed here.
JOIN Question 1: Does the question indicate a need to eliminate duplicates?
Thank you @l-mack , for the review and feedback. |
l-mack
left a comment
There was a problem hiding this comment.
Great job applying the feedback! Approved 30/30.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I found few challenges during Group By, Having, Aggregate functions.
How were these changes tested?
I executed all the queries during assignment and try to get the result verification from the actual data in tables.
A reference to a related issue in your repository (if applicable)
I accidentally created a draw.io file while register for draw.io
Checklist