Add regression test for nested meta path in json_normalize#34090
Merged
jreback merged 1 commit intopandas-dev:masterfrom May 9, 2020
Merged
Add regression test for nested meta path in json_normalize#34090jreback merged 1 commit intopandas-dev:masterfrom
jreback merged 1 commit intopandas-dev:masterfrom
Conversation
MarcoGorelli
reviewed
May 9, 2020
|
|
||
| expected = DataFrame( | ||
| ex_data, | ||
| columns=["name", "population", "state", "shortname", "info.governor"], |
Member
There was a problem hiding this comment.
Thanks @LTe - is it necessary to pass columns here, given that you already provide them as keys to ex_data?
Contributor
Author
There was a problem hiding this comment.
Not really, I can delete this.
Contributor
|
thanks @LTe |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to add regression test for #27220 and make sure that this kind of issues will not be present in the future.
Thanks to @yanglinlee code I created test that works with current
masterbranch.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff