CLN: unify numpy.random-related imports in pandas/tests/plotting#37103
CLN: unify numpy.random-related imports in pandas/tests/plotting#37103onshek wants to merge 208 commits intopandas-dev:masterfrom
Conversation
charlesdong1991
left a comment
There was a problem hiding this comment.
emm, shall we hold this PR up and implement the logic in code_check.sh first and do this whole clean-up in one go by running code_check.sh? I assume this unification might pop up in other files too
|
As noted in #37053 (comment), I would personally like to standardize towards IMO it's easier to reason about where |
jreback
left a comment
There was a problem hiding this comment.
yeah we don't want to do this. apologize if i said this was ok omewhere else. we always want fully qualified imports. We spent a lot of time removing this over the past few years and don't want to add it back. fuly qualified is much more obvious / explicit. what we do want are explicit checks that we are not using the shortcut imports.
|
Fully understand what you said above. Well this PR is still necessary I think, since |
This reverts commit 669bf55.
…#37050)" (pandas-dev#37116) This reverts commit fad14fd.
…v#37102) * VIS: Accept xlabel and ylabel for scatter and hexbin plots * Add issue number note
* CI: docker 32-bit linux build pandas-dev#32709 * fix manylinux version typo * TST/CI: fix 32bit dtype tests pandas-dev#36579, pandas-dev#32709 * TST/CI: xfail 32-bit tests pandas-dev#36579, pandas-dev#32709 * CI: skip test pandas-dev#36579, pandas-dev#32709
|
@onshek can you merge master |
…v#37219) * DOC: Updated resample.py and groupby.py to fix SA04 Errors * DOC: Fixed flake8 issue * pandas-dev#28792 DOC: Fixed SA04 Errors * pandas-dev#28792 Doc Fix SA04 Errors * Update pandas/core/arrays/integer.py Co-authored-by: Joris Van den Bossche <[email protected]> * Update pandas/core/arrays/boolean.py Co-authored-by: Joris Van den Bossche <[email protected]> * pandas-dev#28792 DOC: udpated reviewers comments * pandas-dev#28792 DOC: Fixing flake8 Errors Co-authored-by: Nagesh Kumar C <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Simon Hawkins <[email protected]>
sure, will do it later |
…plotting' of https://github.com/onshek/pandas into issue37053-unify-numpy-related-imports-in-pandas/tests/plotting
…s/tests/plotting' of https://github.com/onshek/pandas into issue37053-unify-numpy-related-imports-in-pandas/tests/plotting" This reverts commit 50a92fb, reversing changes made to 5532ae8.
|
all files are moved to #37492 |
latest update
all files are moved to #37492
(keep this issue open until both CLN: unify numpy.random-related imports in pandas/tests/plotting #37103 and CI: check for numpy.random-related imports #37117 are completed)black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffA separate PR(CI) will be opened to add related code_check(#37117).
PS: Should a whatsnew note be added?update
The whole project is reformatted except
pandas/_testing.pyfor there are quite a fewtm.randnused in testing files.below is the script to do the whole clean-up