UI: Improve design of cancelled task status icon#1760
Open
Meldiron wants to merge 2 commits intopaperclipai:masterfrom
Open
UI: Improve design of cancelled task status icon#1760Meldiron wants to merge 2 commits intopaperclipai:masterfrom
Meldiron wants to merge 2 commits intopaperclipai:masterfrom
Conversation
Contributor
Greptile SummaryThis PR improves the visual design of the "cancelled" task status icon by adding a filled background (
Confidence Score: 4/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: ui/src/components/StatusIcon.tsx
Line: 40
Comment:
**Missing explicit height on SVG**
The `done` indicator sets both dimensions explicitly (`h-2 w-2`) to avoid ambiguity, but the cancelled SVG only sets `!w-2.5` with no corresponding `!h-2.5`. With `absolute inset-0` applied, the positioned box has `top: 0; bottom: 0` which makes the CSS-computed height equal to the parent's height (16px). Since SVG sizing with `viewBox` can conflict with absolute-positioned height constraints, some browsers may render the X stretched vertically (10px wide × 16px tall) rather than as a square icon.
Adding `!h-2.5` would match the same approach used for the `done` dot and guarantee consistent cross-browser rendering:
```suggestion
className="absolute inset-0 m-auto !h-2.5 !w-2.5 text-card"
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: ui/src/lib/status-colors.ts
Line: 19
Comment:
**No dark-mode variant for `bg-neutral-500`**
Every other status with a background fill defines an explicit `dark:` variant (e.g. `dark:text-green-400 dark:border-green-400`). The cancelled entry has always lacked dark-mode variants for its `text-` and `border-` classes, and this PR extends that gap to the new `bg-neutral-500` fill.
In dark mode, `text-card` resolves to `oklch(0.205 0 0)` (very dark / near-black) per the project's `index.css`. A near-black X on `neutral-500` (medium grey) passes the WCAG 3:1 non-text contrast threshold but only just. Adding a slightly lighter background in dark mode (e.g. `dark:bg-neutral-400`) would both align with the existing pattern and provide a bit more contrast for the icon stroke:
```suggestion
cancelled: "text-neutral-500 border-neutral-500 bg-neutral-500 dark:bg-neutral-400",
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "UI: Improve desing of cancelled task sta..." | Re-trigger Greptile |
Meldiron
commented
Mar 25, 2026
Contributor
|
👍 Confirming this works well — I've been wanting the same thing. Applied this diff verbatim on a local fork today and Cancelled now reads as unambiguously different from Backlog in both the list view and the status dropdown, in light and dark mode. Hope this lands upstream soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
Before
After
Verification
Manual QA, as shown in screenshot above. Tests wouldn't benefit UI change too much
Risks
Checklist