Conversation
Contributor
|
@joustrich could you add a Ruby 3.1.x to the test matrix? And maybe we drop 2.6.x. WDYT? |
pcothenet
approved these changes
Oct 12, 2022
Contributor
pcothenet
left a comment
There was a problem hiding this comment.
Looking good, but the issue with the spec seems legit
Author
Sounds good to me! |
rmody3
reviewed
Oct 13, 2022
Comment on lines
+43
to
+47
| describe 'create_order_line_item test' do | ||
| it 'should work' do | ||
| # assertion here. ref: https://www.relishapp.com/rspec/rspec-expectations/docs/built-in-matchers | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
just confirming we will want specs here correct?
Author
There was a problem hiding this comment.
I wasn't sure. Most of these seemed to be empty across the SDKs in favor of integration tests. I added a full integration test for creating an empty order, creating/updating line items, deleting line items and then deleting the draft order in each SDK, which should give pretty good coverage.
rmody3
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
API version 2. See https://docs.patch.io/#/changelog for changes
Why
To support API version 2
SDK Release Checklist