Conversation
added 7 commits
November 17, 2023 14:46
The holder endpoints were removed in the new API version in favor of assigning peers directly with the role endpoints. Goals are now supported
Tests linked to the holder method were removed. Two new tests assign peer and delete assignment were added
mfatima21
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request incorporates the changes fromthe update of the Perrdom API which include the addition of goals as well as the removal of the holder endpoint, replaced by the assign method.
Please only review the change of commit Remove holder methods for assign as the other commits are simply linting the code.
The second part to review are the tests present in Update tests based on assignment update.