Skip to content

Validateaddress wasn't working for non-valid addresses.#10

Closed
x89 wants to merge 6 commits intopetertodd:masterfrom
x89:master
Closed

Validateaddress wasn't working for non-valid addresses.#10
x89 wants to merge 6 commits intopetertodd:masterfrom
x89:master

Conversation

@x89
Copy link
Copy Markdown

@x89 x89 commented May 26, 2014

No description provided.

@petertodd
Copy link
Copy Markdown
Owner

Ha, that's embarrassing... Looks like your unit tests won't work if Bitcoin Core isn't running; maybe they in turn need to check that and disable the test if core isn't available?

@x89
Copy link
Copy Markdown
Author

x89 commented May 26, 2014

Haha, easy to miss!

Erm by bitcoin core do you mean bitcoind running in the background? I haven't actually looked at checking if Bitcoin Core is running, would you mind giving me a pointer? Is there a function in bitcoin.core? I don't immediately see one (I usually just use the rpc and don't fiddle too much with the in-depth bitcoin protocol elements).

@petertodd
Copy link
Copy Markdown
Owner

Yup. Maybe for now you should just "if False:" out that code unittest code with an explanation; I'll think about a better way to do it later.

Also, rebase your code on the current master; github says it can't be merged as-is.

@x89
Copy link
Copy Markdown
Author

x89 commented May 26, 2014

That should do the trick for now.

Edit: Well that.

@petertodd
Copy link
Copy Markdown
Owner

Ok, cleaned this up a bit and merged in f1efbfd

@petertodd petertodd closed this Jun 8, 2014
ghtdak pushed a commit to ghtdak/python-bitcoinlib that referenced this pull request Dec 1, 2015
Python3 fixes
 [ yapified by gitreformat (github/ghtdak) on Mon Nov 30 21:07:11 2015 ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants