Replies: 3 comments 1 reply
-
|
I have added the badge. Not sure where to put the CODECOV_TOKEN or how to send it to you, but it seems to be correct. It shows I have a job to do on the testing side. Things I never felt was very important to test. :) |
Beta Was this translation helpful? Give feedback.
-
|
@Trusted97 I got codecov working with the secret and I did some work to increase the coverage. |
Beta Was this translation helpful? Give feedback.
-
|
Great! I'll start working to increase code coverage too, after that i think we should begin implement PHPStan for static code analysis WDYT? |
Beta Was this translation helpful? Give feedback.
-
|
I think phpstan might be positive for others, but I already use a language server and don't expect it to make a difference. Still, I see the value and agree.
Sendt fra Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
Fra: Gianluca ***@***.***>
Sendt: Monday, June 17, 2024 10:17:19 AM
Til: phasync/phasync ***@***.***>
Kopi: Frode Børli ***@***.***>; Mention ***@***.***>
Emne: Re: [phasync/phasync] Add CodeCov coverage badge (Discussion #32)
Great! I'll start working to increase code coverage too, after that i think we should begin implement PHPStan for static code analysis WDYT?
—
Reply to this email directly, view it on GitHub<#32 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AARRLUEB3YJFTD2Q55K5IKDZH2LQ7AVCNFSM6AAAAABJID3POCVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TOOJRGU3DO>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @frodeborli
In the latest MR we've add CI and a job that upload codecoverage on CodeCov, you should be able to retrieve a token and also a badge that could we add for improve readibility on README and tell to the user the actual code coverage :)
Here you could find the error due to the assence of CODECOV_TOKEN
Beta Was this translation helpful? Give feedback.
All reactions