@nielsdos just one unrelated question regarding dom. Should the DOM_API_VERSION be also bumped in ext/dom/php_dom.h with the recent changes in the dom extension?

Maybe it could be fixed to PHP_VERSION so it's more clear.

@petk There's an open issue for that: #8038. DOM_API_VERSION reflects the implemented standard version. So it shouldn't be equal to PHP_VERSION. Also, since we don't fully implement the living standard yet, bumping it to the last's revision date is too optimistic. I'm not sure what to do with that and I don't know if people depend on its value...

Ok, then let's bump it in PHP 9, I guess. :) Nobody relies on the DOM version anyway because it is constant for many PHP versions.

Searching on GH yields indeed no results: https://github.com/search?q=DOM_API_VERSION+language%3APHP+&type=code
I'd like to just get rid of it in the future as it provides more confusion than value, and from a quick look nobody seems to use it. That's future plans though like you say.

Composer can use it via composer.json and ext-dom set in it:

However, in the code itself checking the version for the DOM extension specifically (phpversion('dom')) is better done by checking the PHP version itself (phpversion()). Yes, this is off-topic of course. Sorry for polluting the PR.

Right, having the DOM_API_VERSION and extension version tied together is unfortunate... :/

Yes, this is off-topic of course. Sorry for polluting the PR.

No worries. In the future let's post our findings in that issue I linked above :)