Deprecated code/moved code cleanup#80
Merged
tyrsson merged 1 commit intophp-db:0.3.xfrom Nov 5, 2025
tyrsson:0.3.x-cleanup
Merged
Deprecated code/moved code cleanup#80tyrsson merged 1 commit intophp-db:0.3.xfrom tyrsson:0.3.x-cleanup
tyrsson merged 1 commit intophp-db:0.3.xfrom
tyrsson:0.3.x-cleanup
Conversation
Expands usage of Override Updates some |bool return types to a narrowed |false Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
simon-mundy
reviewed
Nov 3, 2025
Member
simon-mundy
left a comment
There was a problem hiding this comment.
I just want to check that the ResultSetInterface will have a contract to both Countable and Iterator to ensure we don't end up with a broken Interface like the previous versions where the HydratingResultSet (for instance) doesn't provide all the functionality like it should.
Member
Author
|
None of these changes should affect any of that abstraction. This pretty much just continues the cleanup from the adapter moves. |
Member
Author
|
I would like to handle those changes in a separate PR so the changes are not mixed in with all of these removals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands usage of Override
Updates some |bool return types to a narrowed |false
Signed-off-by: Joey Smith [email protected]
Signed-off-by: Joey Smith [email protected]
Please check the type of change your PR introduces.
Bugfix
Documentation
New Feature
RFC
QA
Other
BC Break?
Description: