Missed that there was a regex as well as inline parsing#2
Merged
amouhzi merged 3 commits intophp-mod:masterfrom Jun 6, 2015
jenolan:master
Merged
Missed that there was a regex as well as inline parsing#2amouhzi merged 3 commits intophp-mod:masterfrom jenolan:master
amouhzi merged 3 commits intophp-mod:masterfrom
jenolan:master
Conversation
amouhzi
added a commit
that referenced
this pull request
Jun 6, 2015
Missed that there was a regex as well as inline parsing
Member
|
Thank you @jenolan for fixig this. |
Author
|
I am looking at adding a sort capability next ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry missed that the parsing of strings is done both inline and as a regex, have modified tit to allow Dev.
Found a few other issues, fixed an exception callout and the micro version number should not be displayed if it is null (ie not 0+) as the fourth level is actually not semantic version compatible.