Merged
Conversation
mikeymike
reviewed
May 21, 2021
| */ | ||
| public function __invoke(CliMenu $menu): void | ||
| { | ||
| $menu->close(); |
mikeymike
reviewed
May 21, 2021
| $builder->addItem( | ||
| $exercise->getName(), | ||
| function (CliMenu $menu) use ($exerciseRenderer, $eventDispatcher, $exercise) { | ||
| $menu->close(); |
Member
Author
There was a problem hiding this comment.
Yep, read the pr description!
mikeymike
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
--debugflag which will print all logging to the console if present.I had to refactor the menu closing, because that was currently done in the
ExerciseRendererwhich seems odd anyway, but that was causing the screen to be cleared after the exercise selected event was triggered, so anything logged then would be overwritten. I've changed it to close the menu as soon as we are in the callback for selecting an exercise.