Updated the documentation for Nova Language Client#2830
Merged
dantleech merged 2 commits intophpactor:masterfrom Jan 27, 2025
Merged
Updated the documentation for Nova Language Client#2830dantleech merged 2 commits intophpactor:masterfrom
dantleech merged 2 commits intophpactor:masterfrom
Conversation
dantleech
reviewed
Jan 27, 2025
.gitignore
Outdated
| /phpactor.schema.json | ||
| /lib/Extension/WorseReflection/stubs | ||
| /.phpbench | ||
| .nova |
Collaborator
There was a problem hiding this comment.
please remove this and consider using a global git ignore file 🙂
dantleech
reviewed
Jan 27, 2025
doc/lsp/nova.rst
Outdated
| .. _lsp_client_nova: | ||
|
|
||
| Nova Code Editor | ||
| ======= |
Collaborator
There was a problem hiding this comment.
the number of = characters should match the length of the title:
Nova Code Editor
================
dantleech
reviewed
Jan 27, 2025
doc/usage/getting-started.rst
Outdated
| Phpactor is known to work as a language server for Emacs_, Kate_, Sublime_, Helix_ and many others, feel free to contribute setup guides for these editors to this documentation. | ||
|
|
||
| .. _vscode-phpactor: https://github.com/phpactor/vscode-phpactor | ||
| .. _PHPactor: https://extensions.panic.com/extensions/emran-mr/emran-mr.phpactor/ |
Collaborator
There was a problem hiding this comment.
It's Phpactor but please reference it as Nova
Contributor
Author
|
@dantleech All done!
After all these years, I did not know this was possible 😅, super handy! One more question:
I am going to change the Extension Name and API to match this, however, for my reference, is it |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dantleech 👋
I just wrote an extension porting your Language Server to Nova Code Editor. As such, I just updated the documentation with the links to the extension library!
P.S please double-check my commit here, I have no idea what the
.rstfiles are, so I just freewheeled by looking at the docs 😅Thanks!
Emran