Ignore indexing files above a certain size#2979
Merged
dantleech merged 3 commits intophpactor:masterfrom Dec 12, 2025
Merged
Conversation
dantleech
reviewed
Dec 6, 2025
lib/Indexer/Model/IndexJob.php
Outdated
| } | ||
|
|
||
| // Skip files that are bigger than a megabyte | ||
| if (($fileInfo->getSize() ?: 0) >= 1e6) { |
Collaborator
There was a problem hiding this comment.
this should at least be configurable as that at least exposes the feature instead of it being a buried implementation detail.
636586f to
89cd4e6
Compare
ae3fa6d to
4b39e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future ideas