[ticket/11010] adding type="url" to 'site_home_url'#1003
Closed
senky wants to merge 1 commit intophpbb:developfrom
senky:ticket/11125
Closed
[ticket/11010] adding type="url" to 'site_home_url'#1003senky wants to merge 1 commit intophpbb:developfrom senky:ticket/11125
senky wants to merge 1 commit intophpbb:developfrom
senky:ticket/11125
Conversation
Contributor
Author
|
Though I am not sure we want this PR at all, because user may want to specify relative URL... |
Collaborator
|
The ticket creation time does not matter. What matters is that the feature has been merged. Your patch should be against latest develop, i.e. should take the merged feature into account. |
Collaborator
|
The descripion says an absolute URL is required for "Main website URL". |
Contributor
Author
|
Ok so I should close this PR and include changes to #1000? |
Collaborator
|
Yes please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue to start using new HTML5 input types:
http://tracker.phpbb.com/browse/PHPBB3-11010
however it was created before PR#915 was merged, so site_home_url needs to be updated to type="url", too.
http://tracker.phpbb.com/browse/PHPBB3-11125
PHPBB3-11010